Closed Gituser143 closed 3 years ago
I think I found an issue. The help page shows s
to be bound to pause rendering, but it does not work. The UI and values continue to be updated.
There doesn't seem to be a case for s
key here:
https://github.com/pesos/grofer/blob/86954fe342c20c58c64535acd6cdd32aab6ee103/pkg/sink/tui/container/overall_container.go#L178
I think I found an issue. The help page shows
s
to be bound to pause rendering, but it does not work. The UI and values continue to be updated.There doesn't seem to be a case for
s
key here:
Oops, I probably missed this in the UI refactor, will fix.
Edit: The functionality exists, it's just p
and not s
I noticed another issue related to pausing. This happens in both proc
and containers
. When the UI is paused (using p
) and you open the help widget (using ?
), when you go back to the main page (proc or containers) (using Esc
) it gets unpaused automatically.
Is this expected behaviour? I couldn't find anything that would unpause the UI when pressing Esc.
I noticed another issue related to pausing. This happens in both
proc
andcontainers
. When the UI is paused (usingp
) and you open the help widget (using?
), when you go back to the main page (proc or containers) (usingEsc
) it gets unpaused automatically.Is this expected behaviour? I couldn't find anything that would unpause the UI when pressing Esc.
This is probably because a selection happens to perform an action/kill. Esc
then deselects it. I'll fix that in the next commit.
@Samyak2 @MadhavJivrajani changes have been made as per comments, additionally, an error box has been introduced to replace the error cursor colour for the proc
page. Let me know if I've missed/need to change anything.
Description
Added a container actions table. Container actions can now be performed by visually selecting an action instead of remembering the key binding.
Fixes #131
Type of change
Please delete options that are not relevant.
Checklist:
go fmt
on my code (reference)Scope of PR:
grofer container
proc
pageEdit: Fixes #123 (Duplicate issue)