search

pest-parser / pest

The Elegant Parser
https://pest.rs
Apache License 2.0
4.67k stars 261 forks source link

Async Pest #974

Open ekechinwokah opened 9 months ago

ekechinwokah commented 9 months ago

Hi - made some changes to use pest in async, largely borrowed from this code discussed in a previous issue.

Is there any interest in merging into the master branch? Either way is fine but wanted to check.

NoahTheDuke commented 9 months ago

It looks like the only changes is from alloc::rc::Rc to alloc::rc::Arc? I think that's a breaking change as the Rc usages are on public-facing apis (structs and functions), and I don't know that we can make such a change without a major version bump.

I wonder what kind of benchmark hits this results in. How much slower is Arc than Rc in Pest?

ekechinwokah commented 9 months ago

Ah, got it. We haven't benchmarked.