search

pest-parser / pest3

WIP pest 3.0
Apache License 2.0
11 stars 3 forks source link

Rename built-in rules to be all lowercase #9

Open tomtau opened 3 months ago

tomtau commented 3 months ago

to make it consistent, since they are not separated by the pest:: module

chriskrycho commented 3 months ago

I’d be happy to do this. To make sure I don’t waste either of our time, though: these, and the others like them in this file?

https://github.com/pest-parser/pest3/blob/08e99257b9d2e9befefe48d655fca9ca9e979f0e/pest/src/typed/template/mod.rs#L1022-L1059

Or something somewhere else?

tomtau commented 3 months ago

Yes, I think that. Off the top of my head, I'm not sure if other place needs patching (maybe somewhere in the generator @TheVeryDarkness ?) as well

TheVeryDarkness commented 3 months ago

@chriskrycho Yes, and you could also update the generated imports here:

https://github.com/pest-parser/pest3/blob/08e99257b9d2e9befefe48d655fca9ca9e979f0e/generator/src/typed/output.rs#L146-L170

Maybe you could also remove these two lines:

https://github.com/pest-parser/pest3/blob/08e99257b9d2e9befefe48d655fca9ca9e979f0e/generator/src/typed/module.rs#L309-L310

tomtau commented 3 months ago

@chriskrycho plus adjusting the inline or .pest file tests and samples

tomtau commented 2 months ago

@chriskrycho would it be ok if I assigned this issue to you?

chriskrycho commented 2 months ago

@tomtau feel free! I will carve out some time later this week or early next to knock it out. Have been enjoying Pest v2 for working on a small programming language… and also feeling very keenly the value that the new stuff in v3 would add!