search

pest-parser / site

This repo contains the source code for https://pest.rs
http://pest.rs/
Apache License 2.0
13 stars 16 forks source link

Error underline in online editor difficult to see for those with colourblindness #12

Closed Keating950 closed 1 year ago

Keating950 commented 2 years ago

Hello,

I am red-green colourblind, and finding the red dashed underline that indicates an error in the online editor is quite difficult. A different colour, such as a bright yellow, would be much easier to spot; alternatively, a thicker line or brighter shade would also be an improvement in terms of accessibility.

nnashwin commented 1 year ago

Hey @tomtau , what is a proposed solution that would be preferred for this issue?

Are we thinking of changing the color scheme of the textarea boxes or changing the color of the underlined text?

If it is the former, what is the preferred color of the textarea box background?

tomtau commented 1 year ago

@tlboright the latter I think. The former would perhaps require changing the overall page colour scheme (the colour schemes of the textarea boxes match the page background).

Jamalam360 commented 1 year ago

Am colour-blind, also agree. might look into a PR or something

LeoDog896 commented 1 year ago

The original codemirror styling uses a distinct and slightly bolder underline (using the wavy dash as seen in monaco editor) - should we just use the default one instead then? new one old one

nathanielknight commented 1 year ago

For reference, the current colours (as far as I can determine) are:

Which has a very poor contrast score: https://coolors.co/contrast-checker/5b364c-253451