Proposal to upgrade site implementations.

pest-parser / site

This repo contains the source code for https://pest.rs

http://pest.rs/

Apache License 2.0

13 stars 16 forks source link

Proposal to upgrade site implementations. #32

Closed huacnlee closed 1 year ago

huacnlee commented 1 year ago

[ ] Switch CodeMirror to Monaco Editor. Monaco Editor have a better API for code editing, for example diagnostics.
[x] Integration Tailwind CSS for better CSS development and add mobile support.
[x] Add Vite as the front-end build tool.
[x] JavaScript to TypeScript and Use React for build view.
[ ] Add a link on top right navigation bar (Before the Book), named Play.

If we agree that, I can do it.

LeoDog896 commented 1 year ago

(We did discuss parcel vs vite in #30, as well as not using tailwind).

I agree with "Add a link on top right navigation bar (Before the Book), named Play."
I do not agree with a switch from codemirror to monaco editor - monaco editor is generally a lot more heavier, and since we don't have a language server that we can use with advanced diagnostics support, I think it would be better to hold off and use codemirror until we can offer more complex features to justify the usage of monaco.

tomtau commented 1 year ago

Yes, I'd second that and prefer keeping the site simpler/lighter. For the more advanced stuff, it's perhaps better to do it in the VSCode extension, and prepare a devcontainer / gitpod file, so that one can easily spin up the full fledged editor in GitHub Codespaces or Gitpod.io ?