search

pest-parser / site

This repo contains the source code for https://pest.rs
http://pest.rs/
Apache License 2.0
13 stars 16 forks source link

Added support for tags labels and localstorage save #55

Closed Specy closed 11 months ago

Specy commented 11 months ago

This PR adds support for labels in the web editor (solves #48). I also added localstorage saving so whenever the page is reloaded or navigated to, the last saved state is loaded. I also had to change the grammar definition for the editor to allow for the tags to be used, it should be correct, but it's better if someone checks on it. I made a personal change by turning the rules inside the rule block in a white color, it should improve readability a bit, do let me know if any of the changes are unwanted. below is a picture of how it currently looks like:

image

tomtau commented 11 months ago

a typescript formatting issue? https://github.com/pest-parser/site/actions/runs/6640097873/job/18044412540?pr=55#step:6:12

tomtau commented 11 months ago 
Checking formatting...
[warn] static/scripts/editor.ts
[warn] Code style issues found in the above file. Run Prettier to fix.
Specy commented 11 months ago

Everything looks good to me. Could you post a comparison of your white color change Vs. the current styling please? A screenshot of each showing the difference would be great

Left is the current pest website, right is my branch image

Jamalam360 commented 11 months ago

Ah yes I see where you mean. Thanks