Set-ItResult: Return distinctive ErrorId depending on switch used

pester / Pester

Pester is the ubiquitous test and mock framework for PowerShell.

https://pester.dev/

Other

3.08k stars 470 forks source link

Set-ItResult: Return distinctive ErrorId depending on switch used #2401

Closed csandfeld closed 10 months ago

csandfeld commented 10 months ago

PR Summary

Set-ItResult updated to return distinctive ErrorId depending on switch used (previously always returned PesterTestSkipped).
- -Inconclusive now returns PesterTestInconclusive
- -Pending now returns PesterTestPending
- Skipped still returns PesterTestSkipped
Invoke-TestItem in Pester.Runtime updated to handle additional ErrorId´s.
Existing Set-ItResult Pester tests re-enabled.

I am not sure if these changes require additional tests and/or documentation updates - let me know if they do.

Related to issue #2400.

PR Checklist

[x] PR has meaningful title
[x] Summary describes changes
[x] PR is ready to be merged
- If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
[ ] Tests are added/update (if required)
[ ] Documentation is updated/added (if required)

fflaten commented 10 months ago

LGTM as a first step. 🙂

I'd prefer to change the output a little, but unfortunately it could be a minor breaking change since it was the only identifier for inconclusive/pending until now. E.g.

  # From
  [!] Test123 is skipped, because INCONCLUSIVE: test 245.6s (143.4s|102.2s)
  [!] Test456 is skipped, because PENDING: test 5ms (2ms|3ms)

  # To (until one or both Are proper result values again)
  [!] Test123 is skipped (inconclusive), because test 245.6s (143.4s|102.2s)
  [!] Test456 is skipped (pending), because test 5ms (2ms|3ms)

nohwnd commented 10 months ago

@fflaten yeah let's not change the output, so we don't break the existing workarounds, while there is no complete solution in place.

nohwnd commented 10 months ago

Merged, thanks guys :)

csandfeld commented 10 months ago

Merged, thanks guys :)

My pleasure :)

billgothacked commented 10 months ago

Okay

On Thu, Nov 9, 2023 at 6:16 AM Christian Sandfeld @.***> wrote:

Merged, thanks guys :)

My pleasure :)

— Reply to this email directly, view it on GitHub https://github.com/pester/Pester/pull/2401#issuecomment-1803813738, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA7FZAWFGUBF4XJELMUNR4DYDTJUBAVCNFSM6AAAAAA6ZLMVRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTHAYTGNZTHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>