Handle tests marked as inconclusive

csandfeld commented 9 months ago

PR Summary

Adds properties to CSharp classes to enable Inconclusive and InconclusiveCount properties on the Pester.Run object.
Adds logic to group and count tests marked as inconclusive.
Pester Report output updated to support Inconclusive counts etc.
Adds deprecation notice shown when Set-ItResult -Pending is used in tests.
NUnit reports updated to handle inconclusive tests (needs thorough review).
Minor changes to help text

Fix #2400

PR Checklist

[x] PR has meaningful title
[x] Summary describes changes
[x] PR is ready to be merged
- If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
[ ] Tests are added/update (if required)
[ ] Documentation is updated/added (if required)

Notes

I think the logic to handle inconclusive tests is sound, but I am looking for feedback on these points

Are implemented changes to NUnit reports sufficient, or did I miss anything?
Does this PR call for new tests or changes to existing ones?
Are documentation updates needed (if so, where)?
Deprecation notice wording and placement

csandfeld commented 7 months ago

Happy new year! 🎆 Thanks for looking into this. It looks great!

Thank you @fflaten and late happy new year to you too (sorry about the response time).

I have tried to address your comments and requested changes, but would appreciate some advise on this one though:

We need some tests to make sure this works and doesn't break in the future. Suggestions:

Add test for behavior and error here

Can I trouble you for an example of what you have in mind that is not already there?

csandfeld commented 5 months ago

@fflaten when you have a moment, please let me know if there is anything else I should do or address to complete this PR.

Thanks

fflaten commented 5 months ago

@fflaten when you have a moment, please let me know if there is anything else I should do or address to complete this PR.

Apologies for the delay. Been occupied with work for a while. We're also waiting on @nohwnd for final review + merge & release.

We need some tests to make sure this works and doesn't break in the future. Suggestions:

Add test for behavior and error here

Can I trouble you for an example of what you have in mind that is not already there?

Can't remember tbh. so just ignore it. I probably missed the existing inconclusive test 🙂

nohwnd commented 5 months ago

& release. <- Not so easy :D My certificate expired because I asked for renew and then went on vacation. I am waiting for a new one.

nohwnd commented 5 months ago

Looking good. I've added cheaper way of checking that the deprecation should be shown so we don't have to inspect every single test on every run.

nohwnd commented 5 months ago

Merged, thank you! :)

csandfeld commented 5 months ago

Thank you for accepting the PR @nohwnd. And thank you @fflaten for you patience with me through the code reviews.

nohwnd commented 5 months ago

No thank you for your work, and sorry for being slow! Same huge thanks for Frode 👏

fflaten commented 5 months ago

Thank you for accepting the PR @nohwnd. And thank you @fflaten for you patience with me through the code reviews.

Thank you for your patience and great work 👏

pester / Pester