Add null check for $host.UI and its properties to avoid race condition (#2383) - Githubissues

pester / Pester

Pester is the ubiquitous test and mock framework for PowerShell.

https://pester.dev/

Other

3.07k stars 469 forks source link

Add null check for $host.UI and its properties to avoid race condition (#2383) #2468

Closed kborowinski closed 3 months ago

kborowinski commented 3 months ago

PR Summary

Added null check for $host.UI and $host.UI.properties to avoid race condition in PowerShell when accessing the properties from multiple threads.

Fixes #2383.

PR Checklist

[x] PR has meaningful title
[x] Summary describes changes
[x] PR is ready to be merged
- If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
[ ] Tests are added/update (if required)
[ ] Documentation is updated/added (if required)

fflaten commented 3 months ago

@nohwnd Maybe include this in 5.6.0 also?

nohwnd commented 3 months ago

/backport rel/5.6.x

nohwnd commented 3 months ago

/backport to rel/5.6.x

nohwnd commented 3 months ago

/backport to rel/5.6.x

nohwnd commented 3 months ago

/backport to rel/5.6.x

nohwnd commented 3 months ago

/backport to rel/5.6.x

github-actions[bot] commented 3 months ago

Started backporting to rel/5.6.x: https://github.com/pester/Pester/actions/runs/9155719911

nohwnd commented 3 months ago

sorry for the spam, I was trying to configure the backport bot.