pester / Pester

Pester is the ubiquitous test and mock framework for PowerShell.
https://pester.dev/
Other
3.11k stars 473 forks source link

Pester Releases RSS Feed Updating Several Times A Day #2566

Closed toddbrownmcis closed 1 month ago

toddbrownmcis commented 1 month ago

Checklist

What is the issue?

I am monitoring the Pester Releases RSS Feed in Microsoft Teams with the RSS connector. It is posting several times a day as though a new release has been added. This is not the case. It seems that release notes with images have a token embedded in the HTML that is changing as the previous token expires. The image under 5.6.0 Release is an example

Expected Behavior

The Pester Releases RSS Feed should only change when new release information is added.

Steps To Reproduce

Subscribe to Pester Releases RSS Feed

Describe your environment

No response

Possible Solution?

Replace private-user-images.githubusercontent.com images with some other image link that does not contain a token.

nohwnd commented 1 month ago

Will have a look in the evening

-j


Od: Todd Brown @.> Odesláno: Thursday, October 3, 2024 5:35:58 PM Komu: pester/Pester @.> Kopie: Subscribed @.***> Předmět: [pester/Pester] Pester Releases RSS Feed Updating Several Times A Day (Issue #2566)

Checklist

What is the issue?

I am monitoring the Pester Releases RSS Feedhttps://github.com/pester/Pester/releases.atom in Microsoft Teams with the RSS connector. It is posting several times a day as though a new release has been added. This is not the case. It seems that release notes with images have a token embedded in the HTML that is changing as the previous token expires. The image under 5.6.0 Releasehttps://github.com/pester/Pester/releases/tag/5.6.0 is an example

Expected Behavior

The Pester Releases RSS Feedhttps://github.com/pester/Pester/releases.atom should only change when new release information is added.

Steps To Reproduce

Subscribe to Pester Releases RSS Feedhttps://github.com/pester/Pester/releases.atom

Describe your environment

No response

Possible Solution?

Replace private-user-images.githubusercontent.com images with some other image link that does not contain a token.

— Reply to this email directly, view it on GitHubhttps://github.com/pester/Pester/issues/2566 or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLYLYMRCBBDHMIX7DUZ2VTZZVP55BFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLJZRGIYTGNBXGSBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGI2TMNBTGY4TANRVU52HE2LHM5SXFJTDOJSWC5DF. You are receiving this email because you are subscribed to this thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

nohwnd commented 1 month ago

I've dropped the image, hope that solves the issue for you.

toddbrownmcis commented 1 month ago

The 5.6.0-rc1 and 5.6.0-beta1 release notes have the same type of image link with a token.

The 5.4.0 release notes has a different type of image link Output is now printed with colors in AzureDevOps: that doesn't have a token associated with it.

I think the 5.6.0-rc1 and 5.6.0-beta1 release notes will still cause differences but 5.4.0 release notes will not.

Thanks for looking into this issue!

toddbrownmcis commented 1 month ago

@nohwnd I confirmed that your fix for the 5.6.0 release worked but the 5.6.0-rc1 and 5.6.0-beta1 releases are still being posted as new releases daily, as you can see in the following screen shot.

image

nohwnd commented 1 month ago

removed from the other ones as well, I don't know if this was some fluke on github side or if there is some special way to insert images, I've always been just using clipping tool and Ctrl+V to insert the images. So maybe it is problem with any release note with images we have, you just can seen the last few maybe?

I will publish more pester versions this or next week hopefully, so feel free to file a new issue is this becomes a problem again.