search

pester / Pester

Pester is the ubiquitous test and mock framework for PowerShell.
https://pester.dev/
Other
3.11k stars 473 forks source link

BeOfType #729

Closed davidwallis closed 6 years ago

davidwallis commented 7 years ago

Certain assertions return the actual type.. but PesterBeOfTypeFailureMessage line 15.. https://github.com/pester/Pester/blob/630077a53bb974b775da0d79b920e438a18e969b/Functions/Assertions/BeOfType.ps1

doesn't contain the , but it's a [${Type}]" expression as in line 26..

is it feasible to add this in?

nohwnd commented 7 years ago

Sure:)

davidwallis commented 7 years ago

Thanks, I would offer to pick this up - but I'm scared of breaking your code..

Incidentally what is the roadmap for 3.x as I noticed you assigned this to 4.1 are no changes happening in this code base?

nohwnd commented 7 years ago

Currently I am focusing on make the v4 work and push it out the door, but if you want to add the feature, then add it to the v3, and I will merge it forward to v4. I assigned it to 4.1 milestone because it is a new feature.