pesto-students / batch-8-NuSlack

A Group-chat application
https://nu-slack.netlify.com/
2 stars 4 forks source link

WIP: Implementing tests for the react components #56

Closed abhi18av closed 5 years ago

abhi18av commented 5 years ago

What does this PR do?

(A brief explanation synthesizing the feature, bug or fix.)

Checklist

(Go over all the following points, and put an x in all the boxes that apply.) (If you're unsure about any of these, don't hesitate to ask. We're here to help!)

Where should the reviewer start?

(Explain where the reviewer should start in order to review the whole addition or subtractions.) :checkered_flag:

How should this be manually tested?

(List of steps to reproduce, corroborate or tests to run. Write this section clear enough so that external users can also follow it and test the fix.)

  1. :one:
  2. :two:
  3. :tada:

Any background context you want to provide?

(Any information regarding the PR that the reviewer should know.) :construction:

What are the relevant tickets?

(Link to issues, related PR, JIRA issues, etc.) Closes #x

Screenshots

(Screenshots of the feature if available.) :camera:

Questions

(If available, to another developer or reviewer.) :question:

abhi18av commented 5 years ago

I've initiated a sibling PR to separate the concerns of adding the components and then updating their tests.

https://github.com/pesto-students/batch-8-NuSlack/pull/57