search

pesto-students / batch-8-NuSlack

A Group-chat application
https://nu-slack.netlify.com/
2 stars 4 forks source link

Update CI to use environment variables while building react app #64

Closed jaspreet57 closed 5 years ago

jaspreet57 commented 5 years ago

In react build process, either set environment variables, or write them in .env file in project root.

Env variable required for now: SERVER_BASE_URL=url-of-backend-server

jaspreet57 commented 5 years ago

@abhi18av would you be working on this? or shall I pick up. we just need it asap.

abhi18av commented 5 years ago

Oh, this just needs to be done on the CIrcleCI config and let's try not to add an .env file.

jaspreet57 commented 5 years ago

yes cool, I am not saying to add .env file, it is just for local environment. You can set environment variables in CircleCi setup also. So if you are going to work on it please assign it to yourself

abhi18av commented 5 years ago

Na, it's cool. I have the wonderful context PR to play with :)

jaspreet57 commented 5 years ago

Ok good

jaspreet57 commented 5 years ago

Closing, as it is done in CircleCi configuration.