pestphp / drift

[WIP] Command-line tool to migrate your PHPUnit tests to Pest
https://pestphp.com/docs/guides/drift
MIT License
28 stars 7 forks source link

tests(migrate): fix use of new syntax #19

Closed owenvoke closed 4 years ago

owenvoke commented 4 years ago

Just need to resolve the following and then #18 can be rebased and merged.

Looks like it's because getRectorClass only supports a single class. And it's not loading the PestCollector? 🤷🏻

Symfony\Component\DependencyInjection\Exception\RuntimeException: Cannot autowire service "Pest\Drift\PHPUnit\ClassMethod\AfterClassToAfterAllRector": argument "$pestCollector" of method "Pest\Drift\PHPUnit\AbstractPHPUnitToPestRector::__construct()" references class "Pest\Drift\PestCollector" but no such service exists.
olivernybroe commented 4 years ago

Now we are back to having a test suite that runs, but fails because of a bug which we haven't fixed yet 👍

Thanks @owenvoke