fix encapsed string conversion

pestphp / drift

[WIP] Command-line tool to migrate your PHPUnit tests to Pest

https://pestphp.com/docs/guides/drift

MIT License

28 stars 7 forks source link

Closed TomasVotruba closed 4 years ago

TomasVotruba commented 4 years ago

Closes #20

Failing CI is unrelated, looks like unfinished RemovePHPUnitClassRectorTest

This error:

Error: Call to a member function dumpFile() on null

will be fixed in #23

TomasVotruba commented 4 years ago

Btw, I didn't found any ECS or any other coding standards. So my code looks like crap :D

Shall I add it?

owenvoke commented 4 years ago

It's probably worth us adding the pestphp/pest-dev-tools package for consistency with our other repos. :thinking: :+1:

olivernybroe commented 4 years ago

@TomasVotruba Thanks a lot for Rector, it's really an amazing tool 👍

It made it so easy for us to make this project.

If you have any comments on how we use rector or how we could do it better, please don't hesitate coming with them :)

TomasVotruba commented 4 years ago

You're welcome. I'm glad I can help devs to be lazy and enjoy their work more :)

After the ECS gets merged, I'll look on Rector setup here. One step at a time

olivernybroe commented 4 years ago

@TomasVotruba Awesome! Thanks 👍

Love being a lazy dev 😉