pestphp / drift

[WIP] Command-line tool to migrate your PHPUnit tests to Pest
https://pestphp.com/docs/guides/drift
MIT License
28 stars 7 forks source link

fix: update tests to work with latest rector #35

Closed owenvoke closed 4 years ago

owenvoke commented 4 years ago

When Rector 0.7.66 releases, we'll need to change the version selector in Composer. 👍🏻

owenvoke commented 4 years ago

My local version of master wasn't up to date, so I've rebased this. 👍🏻

olivernybroe commented 4 years ago

@owenvoke Was just going to say that ;) As I fixed the scenarios you mentioned

owenvoke commented 4 years ago

Seems to be working with the latest Rector and EasyTesting now. 👍🏻 Will wait for Rector to release it's next version.

Does this all seem ok @olivernybroe? 🤔

olivernybroe commented 4 years ago

LGTM! 👍

Was exactly the problem I also had recently.

owenvoke commented 4 years ago

Looks like they went from 0.7.6 to 0.8.0 so I just bumped it to that. 👍🏻

owenvoke commented 4 years ago

After this is merged, I'll work on updating to Pest 0.3 support. :+1:

olivernybroe commented 4 years ago

Sounds awesome! Thanks