Require latest minor version of Drift

pestphp / drift

[WIP] Command-line tool to migrate your PHPUnit tests to Pest

https://pestphp.com/docs/guides/drift

MIT License

28 stars 7 forks source link

Require latest minor version of Drift #38

Closed DannyvdSluijs closed 4 years ago

owenvoke commented 4 years ago

I think there is technically quite a bit more to this than it seems, but I think it's ok to merge this and then I'll work on the rest of the changes tomorrow. @olivernybroe, if that seems ok to you, feel free to merge this. :+1:

olivernybroe commented 4 years ago

@owenvoke It seems fine to me. Not sure what the complications are tbh.

Do you remember why we actually have a requirement for pest?

owenvoke commented 4 years ago

Not sure to be honest. I think the main changes that need to be done is removing the Rector for removing $this from assertions, I was going to add conversions to the expectation API as one of the polish Rectors.

Also, I think there were some other things I saw, but will check tomorrow when I get time.

Looks like this isn't relevant as we never added the $this removal. 🤦🏻 (https://github.com/pestphp/drift/issues/4) Just me being an idiot. So nothing for us to do. 👍🏻