search

pestphp / pest-plugin-drift

The Pest Drift Plugin
https://pestphp.com
MIT License
68 stars 7 forks source link

feat: remove annotations when converting tests #14

Closed mandisma closed 1 year ago

mandisma commented 1 year ago

Resolves #8

schonhoff commented 1 year ago

Hi,

wouldn't this remove the entire comment even if there are @group tags? See: https://github.com/pestphp/pest-plugin-drift/issues/16

mandisma commented 1 year ago

Hi,

Yes this will remove the entire comment. The group tag key needs to be converted. I will open a PR that will handle this.

Thanks for the feedback.

nunomaduro commented 1 year ago

Can you address the conflicts?

schonhoff commented 1 year ago

Hi,

Yes this will remove the entire comment. The group tag key needs to be converted. I will open a PR that will handle this.

Thanks for the feedback.

Hi,

thanks for the PR. While I looked at it another thing could be @todo as annotation. Maybe that should be converted to Pests todo? I'm not sure but maybe it could be useful.

Thanks for the great work and keep it going :-)