Closed JonPurvis closed 8 months ago
Hey @owenvoke 👋
Do you have any idea whats up with the failing tests on this PR? Static Analysis is failing but doesn't seem to actually be related to this PR
PHPStan\Analyser\NodeScopeResolver::__construct(): Argument #9 ($signatureMapProvider) must be of type PHPStan\Reflection\SignatureMap\SignatureMapProvider, PHPStan\PhpDoc\PhpDocInheritanceResolver given, called in /home/runner/work/pest/pest/vendor/pestphp/pest-plugin-type-coverage/src/PHPStanAnalyser.php on line 71
Any help would be much appreciated!
Thanks
Hey @owenvoke 👋
Do you have any idea whats up with the failing tests on this PR? Static Analysis is failing but doesn't seem to actually be related to this PR
PHPStan\Analyser\NodeScopeResolver::__construct(): Argument #9 ($signatureMapProvider) must be of type PHPStan\Reflection\SignatureMap\SignatureMapProvider, PHPStan\PhpDoc\PhpDocInheritanceResolver given, called in /home/runner/work/pest/pest/vendor/pestphp/pest-plugin-type-coverage/src/PHPStanAnalyser.php on line 71
Any help would be much appreciated!
Thanks
I have fixed it in https://github.com/pestphp/pest-plugin-type-coverage/pull/15. Just waiting to be merged!
Awesome, thanks for letting me know @faissaloux 😄
Hey @devajmeireles
Would you be able to re-run the checks on this PR please? I believe the 2 failing ones should now pass thanks to https://github.com/pestphp/pest-plugin-type-coverage/pull/17
Thanks!
Hey @nunomaduro 👋
Would you be open to having these 2 new Arch Expectations in Pest? I'm going through my open PR's before the end of the year in an effort to get them merged/closed.
I look forward to hearing from you!
Thanks
Thank you! 🥳
What:
Description:
We already have the very handy
toBeEnum()
Arch Expectation, which is useful for Pure Enums. This PR adds 2 similar Expectations, specifically for Backed Enums:toBeStringBackedEnum()
toBeIntBackedEnum()
By writing the following test, we can ensure that it is actually a String Backed Enum.
We could also change the test if the Enum returned an Int:
Docs: https://github.com/pestphp/docs/pull/247