search

pestphp / pest

Pest is an elegant PHP testing Framework with a focus on simplicity, meticulously designed to bring back the joy of testing in PHP.
https://pestphp.com
MIT License
9.07k stars 315 forks source link

[2.x] Modify `Result::exitCode` logic to address warning handling with `--fail-on-warning` #1097

Open arifszn opened 4 months ago

arifszn commented 4 months ago

What:

Description:

Pest now fails (non-zero exit code) when warnings are encountered with the --fail-on-warning flag. Previously, it passed (zero exit code) even with warnings present as it returned SUCCESS_EXIT before checking the warning count.

Related:

Fix #1074.

arifszn commented 1 day ago

Ping @nunomaduro