search

pestphp / pest

Pest is an elegant PHP testing Framework with a focus on simplicity, meticulously designed to bring back the joy of testing in PHP.
https://pestphp.com
MIT License
9.62k stars 358 forks source link

chore: missing tests against PHP 8 #127

Closed nunomaduro closed 4 years ago

nunomaduro commented 4 years ago

Currently, the test suite is testing against PHP 7.3, and PHP 7.4. To fix this issue, you should make sure our test suite is testing also against PHP 8. So we can be prepared for PHP 8 before it gets released. 👍🏻

To get started you should update https://github.com/pestphp/pest/blob/3eb0a95955750e4a83749d24462076e5aa1e9a33/.github/workflows/tests.yml#L12.

Finally, and if tests are failing, you should update the source code until the tests are passing.

nunomaduro commented 4 years ago

@driesvints is also trying to test the Laravel Core against PHP 8: https://github.com/laravel/framework/compare/php-8-builds. His work may help us here.

GrahamCampbell commented 4 years ago

Laravel PHP 8 is coming along well now. A big blocker was Mockery, but I fixed up all that: https://github.com/mockery/mockery/pull/1072. It looks like you are facing a similar issue to mockery.

GrahamCampbell commented 4 years ago

I think you can just delete these lines entirely. They are never hit:

image
GrahamCampbell commented 4 years ago

Ish. I'll PR.