Add the `update` method in `TrustedDomain`

henry0715-dev commented 3 months ago

Close #327

Summary by CodeRabbit

New Features
- Added support for multilingual data updates with a new language parameter in the account update process.
- Introduced a category field for improved data categorization and querying.
- New methods for managing trusted domains, allowing for safer retrieval and updates of TrustedDomain entries.
Bug Fixes
- Enhanced error handling for trusted domain updates to ensure robust operations.
Tests
- Added test cases to validate the functionality of the new update method for trusted domains.

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes enhance the Table<'d, Account>::update method by introducing a language parameter for improved multilingual data management. A new category field has been added to the database and rules, promoting better structured data handling. Additionally, an update method for TrustedDomain has been introduced, refining the management of trusted domains. Overall, these updates significantly bolster the application's functionality and flexibility.

Changes

Files	Change Summary
`CHANGELOG.md`, `src/tables/...`	Enhanced `Table<'d, Account>::update` with `language` parameter; added `category` field; new `update` method for `TrustedDomain` with error handling.
`src/tables/trusted_domain.rs`	Updated `TrustedDomain` struct to derive additional traits and added an `update` method for better management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant Database

    User->>Application: Request account update (with language)
    Application->>Database: Update account with new language
    Database-->>Application: Confirm update
    Application-->>User: Acknowledge update success

    User->>Application: Request TrustedDomain update
    Application->>Database: Update TrustedDomain entry
    Database-->>Application: Confirm update
    Application-->>User: Acknowledge TrustedDomain update success

Assessment against linked issues

Objective	Addressed	Explanation
Add update method for TrustedDomain (#327)	✅

🐰 Hop, hop, hooray for changes bright,
New languages and domains take flight!
With updates and gets, our data's a treat,
In the code garden, we dance on our feet!
With structure and ease, we’ll frolic and play,
A vibrant new world, hip-hip-hooray! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

sehkone commented 3 months ago

I think we need to discuss this further regarding whether get is necessary, and others.

henry0715-dev commented 3 months ago

I think we need to discuss this further regarding whether get is necessary, and others.

I think it is necessary to satisfy the following conditions.

sehkone commented 3 months ago

I think we need to discuss this further regarding whether get is necessary, and others.

I think it is necessary to satisfy the following conditions.

I think the trusted_domain_list method of review-web already provides what the conditions require.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.84%. Comparing base (c3343e3) to head (85d2428). Report is 1 commits behind head on main.

Files	Patch %	Lines
src/tables/trusted_domain.rs	95.83%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #328 +/- ## ========================================== + Coverage 61.79% 61.84% +0.04% ========================================== Files 97 97 Lines 19293 19317 +24 ========================================== + Hits 11923 11946 +23 - Misses 7370 7371 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sehkone commented 3 months ago

@henry0715-dev Could you remove [WIP] that is not necessary any longer? And, I suggest this commit message:

Add the update method in TrustedDomain

@sophie-cluml Could you review this PR?

sehkone commented 3 months ago

And, I suggest this commit message:

Add the update method in TrustedDomain

I think this message should apply to the title of this issue as well.

petabi / review-database