petabi / review-database

Storage subsystem for REview
Apache License 2.0
1 stars 7 forks source link

Switch back to diesels query builder (model) #330

Closed atyoshioka closed 3 months ago

atyoshioka commented 3 months ago

Use diesel's query builder in model.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates introduce a significant refactor in the database handling code, shifting from raw SQL queries to leveraging the Diesel ORM for improved readability and maintainability. Several public methods for data deletion and selection in the PostgreSQL backend have been removed, indicating a streamlined approach to database interactions. This modernization simplifies the codebase while enhancing type safety and reducing potential errors.

Changes

Files Change Summary
src/backends/postgres.rs Removed several public methods and query-building functions for data deletion and selection, streamlining the database interaction layer.
src/model.rs Refactored database interaction to use Diesel ORM methods, enhancing code readability and maintainability by replacing raw SQL with Diesel's query builder.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Database
    participant DieselORM

    Client->>Database: Request to add model
    Database->>DieselORM: Insert model using insert_into
    DieselORM-->>Database: Confirmation of insert
    Database-->>Client: Return success

    Client->>Database: Request to delete model
    Database->>DieselORM: Delete model using delete
    DieselORM-->>Database: Confirmation of delete
    Database-->>Client: Return success

Poem

In a garden, a rabbit hops with glee,
β€œOh, look at the code, so neat and free!
No more tangled SQL, just Diesel's grace,
Simplified queries, a joyous embrace.
With each little change, our code's in bloom,
Hooray for the updates, let’s make some room!” πŸ‡βœ¨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 140 lines in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (c3343e3) to head (aa34476). Report is 1 commits behind head on main.

Files Patch % Lines
src/model.rs 0.00% 140 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #330 +/- ## ========================================== - Coverage 61.79% 61.72% -0.08% ========================================== Files 97 97 Lines 19293 19151 -142 ========================================== - Hits 11923 11821 -102 + Misses 7370 7330 -40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.