search

petabridge / NBench

Performance benchmarking and testing framework for .NET applications :chart_with_upwards_trend:
https://nbench.io/
Apache License 2.0
532 stars 46 forks source link

Skip not working? #80

Closed Benjol closed 8 years ago

Benjol commented 8 years ago

Maybe I haven't understood what it's supposed to do, but if you take your sample code and add Skip="whatever" and then do NBench Runner on it, it gets run.

Aaronontheweb commented 8 years ago

@Benjol should be working - I'll double check

Aaronontheweb commented 8 years ago

@Benjol fixed! Will be out in the next release, which I intend to do ASAP.

Benjol commented 8 years ago

Great, thanks!

Aaronontheweb commented 8 years ago

Argh, still having an issue with this in NBench v0.2.1, which is weird because my spec verifying that skipped benchmarks don't run passes >_<

Aaronontheweb commented 8 years ago

Nevermind, this was fixed already - had a NuGet issue in the project I was testing this in that was using the old v0.1.5 runner.