petabridge / akkadotnet-healthcheck

Healthchecks for Akka.NET Applications :hospital:
Apache License 2.0
20 stars 9 forks source link

Cluster readiness reports Healthy when still not joined #279

Closed danielmoriya closed 2 months ago

danielmoriya commented 3 months ago

I'm adding the latest Akka.HealthCheck.Cluster package. Although the Readme says that it will return unhealthy when Actor system, is up, but still not joined the cluster, the results I'm getting a Healthy status with just the message for both liveness and readiness, that still not joined.

        "akka-live-cluster": {
            "data": {
                "message": "not yet joined cluster"
            },
            "description": "Akka.NET cluster is alive",
            "duration": "00:00:00.0000842",
            "status": "Healthy",
            "tags": [
                "akka",
                "live",
                "cluster"
            ]
        },
        "akka-ready-cluster": {
            "data": {
                "message": "not yet joined cluster"
            },
            "description": "Akka.NET cluster is ready",
            "duration": "00:00:00.0000657",
            "status": "Healthy",
            "tags": [
                "akka",
                "ready",
                "cluster"
            ]
        }
Arkatufus commented 3 months ago

We relaxed the cluster healthcheck rules here: https://github.com/petabridge/akkadotnet-healthcheck/pull/238 Basically, the readiness probe only returns unhealthy if all other nodes in the cluster is unreachable