search

petalframework / petal_components

Phoenix + Live View HEEX Components
https://petal.build/components
MIT License
818 stars 94 forks source link

Slide over not showing up after updating to 1.7.0 #269

Open samuelpordeus opened 11 months ago

samuelpordeus commented 11 months ago

what is happening

we have a slide over that isn't opening after updating to 1.7.0 and some others aren't respecting the origin (it should come from the right side, but it's not)

clues

i don't think it's related to the changes we made to add close_slide_over_target attr. i suspect that is related to this commit: https://github.com/petalframework/petal_components/commit/2242a9ca324eec2444ed5b943dece056da243560

how we are calling the component:

<.form for={@form} id={@id} class="grow" phx-target={@myself} phx-change="validate" phx-submit="submit">
  <.slide_over origin="right" max_width="lg" title={@title}>
mplatts commented 11 months ago

Hmm. Do you have multiple slide overs on one page? maybe the hardcoded ID needs to be updated like with modal.

samuelpordeus commented 11 months ago

@mplatts we had a custom ID, but I noticed that it only works if we remove it and use the hardcoded one instead.

But removing that doesn't solve the animation issue. It should come from the right but it's not:

<.slide_over origin="right" max_width="lg" title={@title}>

Oct-18-2023 09-12-52

we can see here that it displays the correct animation when closing tho