search

petalframework / petal_components

Phoenix + Live View HEEX Components
https://petal.build/components
MIT License
767 stars 84 forks source link

Feature: Allow groups in nested item #280

Open Gigitsu opened 7 months ago

Gigitsu commented 7 months ago

This allows the use of groups in nested menu items.

mplatts commented 7 months ago

Thanks! Can you provide a screenshot and also add a test?

Gigitsu commented 7 months ago

Sure! I will provide screenshots and a test asap.

Gigitsu commented 7 months ago

Hi @mplatts, I've added tests. Could you please let me know if they are sufficient?

Here are some screenshots:

Gigitsu commented 7 months ago

This is how it is rendered; each nested group is separated by the same gap as the non-nested groups.

rendered wireframe

Gigitsu commented 7 months ago

Hi @mplatts, have you had the chance to check the updates?

mplatts commented 7 months ago

Hey sorry, been a bit swamped. Will take a look this weekend.

Gigitsu commented 7 months ago

No hurry :) just asking. Thank you.

Gigitsu commented 1 month ago

Hi @mplatts, do you have any plan to merge this?