petalframework / petal_components

Phoenix + Live View HEEX Components
https://petal.build/components
MIT License
767 stars 84 forks source link

SlideOver no longer receiving close_slide_over event on click-away on PhoenixLiveView 0.20.2 #284

Open tjchambers opened 6 months ago

tjchambers commented 6 months ago

Environment

Elixir version (elixir -v): 1.15.4 Phoenix version (mix deps): 1.7.10 Phoenix LiveView version (mix deps): 0.20.2 Operating system: MacOS Browsers you attempted to reproduce this bug on (the more the merrier): Safari Does the problem persist after removing "assets/node_modules" and trying again? Yes/no: no Actual behavior

Click link that Opens slide over Slide over opens (good) Click underlying page (outside of slideover) No handle_event is fired to close_slide_over Expected behavior

on 0.20.1 behavior was:

Click on link that opens slider over Slide over handle_event is triggered and appears (same and good) Click anywhere outside slide_over on page (whitespace, another link, etc.) Handle_event to close_slide_over is fired and handled and slide_over disappears I suspect this is a regression, as I am no longer getting any close_slide_over handle_event unless I click the close button on the slide over itself which leads to a very poor UX.

tjchambers commented 6 months ago

Reported here: https://github.com/phoenixframework/phoenix_live_view/issues/2964