search

petar-dambovaliev / aho-corasick

efficient string matching in Golang via the aho-corasick algorithm.
MIT License
68 stars 11 forks source link

Should Opts structs fields be exported ? #1

Closed ibrierley closed 3 years ago

ibrierley commented 3 years ago

Hi, thanks for the work on this. I'm having a few issues with the Opts struct (I'm relatively new to Go). I seem to get an exported issue with it, so wondering if the fields should be in caps ?

petar-dambovaliev commented 3 years ago

Hi, thanks for the work on this. I'm having a few issues with the Opts struct (I'm relatively new to Go). I seem to get an exported issue with it, so wondering if the fields should be in caps ?

Yea, already did it. Thanks for the issue. I've been working on this for 2 days only. Please, report if you see any problems.

ibrierley commented 3 years ago

Works great, thanks for all of the help.

Ian

On Fri, Apr 23, 2021 at 8:13 PM Petar Dambovaliev @.***> wrote:

Closed #1 https://github.com/petar-dambovaliev/aho-corasick/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/petar-dambovaliev/aho-corasick/issues/1#event-4638470322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5YN5NKKMCAQ2KKQ7YGQI3TKHBEJANCNFSM43PFJR3Q .