search

petdance / bobby-tables

bobby-tables.com, the site for preventing SQL injections
http://bobby-tables.com/
248 stars 85 forks source link

Creates ADO.NET page and ADO.NET ORM page #85

Closed zspitz closed 6 years ago

zspitz commented 6 years ago

Fixes #79

This page now supersedes the previous C# and .NET pages, and part of the ASP page.

@mason-mcglothlin @kimmel @deanebarker As previous contributors to these pages, could you look over this and see if I've missed anything?

Question: do we also need an example for preventing SQL injection when syncing edited data from a dataset back to the data source? Is this a reasonable scenario? (I've never used a dataset in this way.)

petdance commented 6 years ago

Thanks for this. Will try to look at it this weekend.

petdance commented 6 years ago

Can you say more please about how this update supersedes the other pages? How exactly? I don't know anything about this ecosystem.

mason-mcglothlin commented 6 years ago

@petdance

Data access in any .NET application is done in the same way. C# is just a language in .NET. So it didn't make sense to have .NET and C# split onto different pages. ASP.NET is a web application framework that's part of .NET, so that didn't make sense to separate out either. We can combine all of these and then we won't have to maintain separate examples.

I will look into the changes when I have a bit more time to go over them, hopefully this evening.

petdance commented 6 years ago

So you're combining two related pages into one? That makes sense, thank you. My concern was that we might be losing information about older languages that still might be being used.

petdance commented 6 years ago

It seems like you're still working on this PR, correct? Can you please delete the PR and then make a new one when you're ready for me to merge it?

petdance commented 6 years ago

This has been closed and reopened as #86