petdance / html-tidy5

HTML::Tidy5, Perl module for checking HTML5, based on https://github.com/htacg/tidy-html5
5 stars 3 forks source link

Several test failures on freebsd #16

Open eserte opened 9 months ago

eserte commented 9 months ago

See subject. I see test failures like this:

    #   Failed test at t/drop-empty-elements.t line 34.
    #     Structures begin differing at:
    #          $got->[0] = 'test (4:9) Warning: blank 'title' element'
    #     $expected->[0] = 'test (7:9) Warning: trimming empty <span>'
    # Looks like you failed 1 test of 2.

#   Failed test 'default constructor warns about empty spans'
#   at t/drop-empty-elements.t line 37.

    #   Failed test at t/drop-empty-elements.t line 46.
    #     Structures begin differing at:
    #          $got->[0] = 'test (4:9) Warning: blank 'title' element'
    #     $expected->[0] = 'test (7:9) Warning: trimming empty <span>'
    # Looks like you failed 1 test of 2.

#   Failed test 'drop_empty_elements => 1 gives message'
#   at t/drop-empty-elements.t line 49.

    #   Failed test at t/drop-empty-elements.t line 58.
    #     Structures begin differing at:
    #          $got->[0] = 'test (4:9) Warning: blank 'title' element'
    #     $expected->[0] = Does not exist
    # Looks like you failed 1 test of 2.

#   Failed test 'drop_empty_elements => 0 gives no messages'
#   at t/drop-empty-elements.t line 59.
# Looks like you failed 3 tests of 3.
t/drop-empty-elements.t .... 
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/3 subtests 
... etc, more failures exist ...
petdance commented 1 month ago

This is because you're using tidy 5.8.0, and 5.8.0 generates tags that are empty, but empty <title> tags are non-tidy.</p> <p>Next version of HTML::Tidy5 will handle that, and will require tidy 5.8.0.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>