petdance / tidyp

tidyp, a fork of the original tidy
36 stars 8 forks source link

files from tests/ not included in tarball #13

Open danielj7 opened 14 years ago

danielj7 commented 14 years ago

The files from tests/ need to be added to EXTRA_DIST in tests/Makefile.am as they don't get added to the tarball which breaks the test suite.

petdance commented 14 years ago

patch please! Pleeeeease!

danielj7 commented 14 years ago
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 3da6639..65aec0f 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,3 +1,20 @@
 # Nothing

-EXTRA_DIST = input/ output/ accessibility/
+EXTRA_DIST = \
+       input/ \
+       output/ \
+       accessibility/ \
+       accesscases.txt \
+       acctest.cmd \
+       alltest.cmd \
+       alltest1.cmd \
+       onetest.cmd \
+       onetesta.cmd \
+       testaccess.sh \
+       testaccessone.sh \
+       testall.sh \
+       testcases.txt \
+       testone.sh \
+       testxml.sh \
+       xmlcases.txt \
+       xmltest.cmd
petdance commented 14 years ago

I'll apply this later tonight.

The slicker, githubbier way to do this (and not mess with markdown in the ticket) is to fork my petdance/tidyp repo, check out your forked version, and make your changes there, and push back to github. At that point, your change will be on danielj7/tidyp. Then, you send me a pull request and I can pull your change directly out of the repo. No patch sending necssary. It's super slick.

http://help.github.com/forking/

http://help.github.com/pull-requests/

danielj7 commented 14 years ago

Thanks! I'm still learning my way around git. Too many years of using cvs has caused brain damage. :)