function shut in machine.c and main.c should be static,

pete-gordon / oricutron

Portable Oric-1/Atmos/Telestrat and Pravetz 8D emulator

http://www.petergordon.org.uk/oricutron/

GNU General Public License v2.0

69 stars 25 forks source link

Closed 0ric1 closed 4 years ago

0ric1 commented 4 years ago

implementation of shut in machine.c is missing that causes errors on some compilers.

polluks commented 4 years ago

Indeed, gcc6 fails.

0ric1 commented 4 years ago

In 687d1eafe29701364c140b9476e8d9920b1638be I added static and empty implementation.

0ric1 commented 4 years ago

On WSL with Ubuntu and gcc-6 (Ubuntu 6.5.0-2ubuntu1~18.04) 6.5.0 20181026 it compiles fine (with some warnings).

polluks commented 4 years ago

@Blonder Hmm, why do we need this empty function at all? Right now the MorphOS port is hanging at startup :(

iss000 commented 4 years ago

IMO, the best is to leave 'shut' as is (i.e. public), add its prototype in 'main.h' and call it from 'machine.c' with proper parameters.

iss000 commented 4 years ago

BTW, Linux port hangs too! What is interesting only SDL hangs, SDL2 works!

iss000 commented 4 years ago

Fixed in 606cb80. New issue created about context related hang.