Closed bwhite001 closed 2 months ago
src/pages/MilestoneReport/MilestoneReport.ts
None - a9d1a3:
createRoot
Root
getMilestoneData
Added a comment to clarify the filtering logic for achievements in the getMilestoneData method. src/pages/MilestoneReport/components/MilestoneReport.tsx
None - 49d9a7:
Adjusted the column settings in the GridComponent for consistency with the table changes. src/pages/MilestoneReport/models/MilestonePlanningItem.ts
None - 91f6a9:
TerrainAchievementsEventCount
MilestoneObject
MilestoneRequirements
MilestoneCurrent
calculateMilestone
calculateEventResult
calculateOverallPercent
MilestonePlanningItem
overall_percent
personalGrowth
personal_growth
maxL
maxA
maxP
eventCount
@bwhite001 let me know if you are ok for me to delete the branch now it is accepted and if we want to do this as the standard process.
src/pages/MilestoneReport/MilestoneReport.ts
None - a9d1a3:
createRoot
andRoot
in the file.getMilestoneData
method to include detailed documentation with JSDoc comments.getMilestoneData
method to sort achievements before filtering them based on certain criteria.Added a comment to clarify the filtering logic for achievements in the
getMilestoneData
method. src/pages/MilestoneReport/components/MilestoneReport.tsxNone - 49d9a7:
Adjusted the column settings in the GridComponent for consistency with the table changes. src/pages/MilestoneReport/models/MilestonePlanningItem.ts
None - 91f6a9:
TerrainAchievementsEventCount
to the import statement in the file.MilestoneObject
and classesMilestoneRequirements
andMilestoneCurrent
implementingMilestoneObject
.calculateMilestone
,calculateEventResult
, andcalculateOverallPercent
.MilestonePlanningItem
by adding a new propertyoverall_percent
.personalGrowth
topersonal_growth
in theMilestonePlanningItem
class.MilestonePlanningItem
to calculate values based onMilestoneRequirements
andMilestoneCurrent
.maxL
,maxA
,maxP
, andeventCount
in theMilestonePlanningItem
constructor.