search

pete-mc / Summit

Where Every Achievement is a Summit Conquered - Terrain | Summit adds usability features to the Australia Scouts Terrain website.
https://www.facebook.com/groups/scoutsterrain
MIT License
6 stars 1 forks source link

Bug: Incorrect information on Milestone Planning Report #43

Closed CrispyCamper closed 9 months ago

CrispyCamper commented 9 months ago

Describe the bug The Milestone Planning Report shows partially incorrect information. In this example, 'B' is all correct, but 'A', 'C', 'H', 'M', & 'P' all have incorrect leads listed. Compare this report to the equivalent Topo report which shows the correct information.

To Reproduce Steps to reproduce the behavior:

  1. Generate a Topo Milestone report
  2. Generate a Summit Milestone Planning report
  3. Check for inaccuracies

Expected behavior The correct information should be shown, matching the Topo report

Screenshots 20240101_172841 'C' has 1 lead left, 'A', 'H', 'M', & 'P' all have 2 leads left. (Correct)

Screenshot_20240101_173104_Terrain Summit 'C' supposedly has 2 leads left, 'A', 'H', 'M', & 'P' all supposedly have 3 leads left.

Additional notes Again, as mentioned in Issue #42 the buttons at the top (Print & Export to CSV) are this time doubled up.

AceLeader2023 commented 9 months ago

This is experienced on the Chrome version of 2.3.0 as well.

Output with expect values column added image

Then topo report image

Thought I would add to my post with the outcomes and expect values for large area of data

pete-mc commented 9 months ago

Adding to next release backlog. Thanks for taking the effort to explain this really well, it speeds up the time it takes to sort out the issues.

pete-mc commented 9 months ago

Worked out the issue, my totals were the wrong way around between leads and assists. This will released be in 2.40.