petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

Sage renames bookmark when loading feed #12

Open petea opened 11 years ago

petea commented 11 years ago

Original author: theacad...@gmail.com (April 21, 2010 17:47:01)

What steps will reproduce the problem?

  1. Perform a usual subscriptions to a RSS feed in FF.
  2. Rename the feed in your bookmarks.
  3. Click the name of the feed in Sage. Sage reverts name.
  4. Rename bookmark in FF bookmarks.
  5. Click the renamed feed in Sage. No rename this time.

What is the expected output? What do you see instead? Often, blogs and feeds are given the less-than-creative name of "blog" or "feed". So I carefully renamed them in my bookmarks. Firefox by default never overwrote the change. When I first used the Sage summary page for a feed, it overwrote the bookmark/feed name with the title of the blogs or feed, i.e. they switched back to "blog" or "feed". It does not if you right-click and select "Open All in Tabs", or "Reload Live Bookmark".

What version of the product are you using? On what operating system? Sage 1.4.6 in FF 3.6.3 on Vista

Please provide any additional information below. Once you rename them back, it seems to leave it alone. It appears to overwrite only on the first time you load it in Sage.

Original issue: http://code.google.com/p/sage/issues/detail?id=12

petea commented 11 years ago

From Peter.A....@gmail.com on July 21, 2010 16:55:52 This behavior is by design, but perhaps it's time to revisit the thinking behind it. The first time Sage loads a feed, it automatically renames the bookmark using the title from the feed itself. This is to get around the problem of poor labeling that you point out. After that initial load, Sage will only rename the bookmark to match the feed title if you haven't changed it. So after you've loaded the feed once, you can go in and customize the titles of your feed bookmarks, and Sage won't touch them. The problem here is that if you customize the title of the bookmark before Sage gets a chance to load the feed, it will wipe out your changes on its first load.

One solution would be to have a more thorough feed add flow, which loads and names the feed for you as part of creating the bookmark. This way, title changes afterward wouldn't be wiped out when viewing the feed for the first time.

petea commented 11 years ago

From theacad...@gmail.com on July 28, 2010 20:01:33 Even a simple "Do you want to rename this feed to:" and the feed title and Y/N buttons.

petea commented 11 years ago

From giunta.g...@gmail.com on March 12, 2011 11:45:33 I just enabled sage in moz 4.0rc1 (since sage++ is not compatible yet). Old folders for feeds there, all got renamed (possibly because sage thinks it's the 1st run). Please make an option to never rename the feeds at all...

devurandom commented 9 years ago

I love the renaming and think it is a (tiny) first step in the (right) direction of #118.