search

petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

Conflict with latest Tab Mix Plus? #123

Closed inspector71 closed 10 years ago

inspector71 commented 10 years ago

Updated to Sage 1.5.2b3, Tab Mix Plus 0.4.1.1pre.130722a and am running Aurora 24.0a2 (2013-07-28).

Seem to have lost the setting to automatically open feed items in a new tab which I think previously was take care of by Tab Mix Plus (I think).

Additionally the "Select Feed Folder" select box list in the Sage options dialogue is not being populated.

Regardless I can still download feeds at least.

petea commented 10 years ago

Does disabling Tab Mix Plus correct the problem with the feed folder drop down?

inspector71 commented 10 years ago

Using Aurora 24.0a2 (2013-07-29), Sage 1.5.2b4, TMP 0.4.1.1pre.130722a on a different machine (Windows 7 instead of XP) I do not get the feed folder drop down problem. I'll run your requested test at home in about 7 hours times from now. Under the above setup, I'm still seeing the wrong default for opening feeds ("Open" in current tab, not "Open in New Tab").

inspector71 commented 10 years ago

Back on my XP machine (and 24 hours late, sorry!) and I just updated to Sage 1.5.2b4, TMP 0.4.1.1pre.130731a and Aurora 24.0a2 (2013-07-30) and the feed select drop down box is all fine. The open in new tab problem is still around though. Even a couple of days of this problem is a bit annoying :(

petea commented 10 years ago

Currently, Sage does not have an option to automatically open feed items in a new tab. Perhaps what you're describing is a Tab Mix Plus issue?

inspector71 commented 10 years ago

That's certainly possible. I remember this came up a while back and I remember discussing it, perhaps with you Peter. Unfortunately I do not remember the details of that discussion and the solution :( I'll see what I can do to analyze the matter and try to document the solution this time :) Thanks for your consideration and continued work on Sage. If you don't mind I'll leave this issue open for a while until I analyze the problem?

Filbert-Cobb commented 10 years ago

I have similar issue with latest Sage, Tab Mix Plus, FF 22 - won't open numbered Sage links in new tabs with left click. Earlier versions of Sage are OK for that feature, but bugged by non-function of mark all as read, and Sage red dot icon always on. I can live with that - but not without TMP, or having to R-click for new tab. Annoying thing is that all was working fine as intended - but went u/s without any apparent changes. I have turned auto-updates off.

inspector71 commented 10 years ago

Thanks for your input Filbert-Cobb. I'm currently discussing this matter in the TMP forum so hopefully an answer will present itself soon. I'll update this issue if it does.

inspector71 commented 10 years ago

Looks like we might have a solution on the cards. Pete can you confirm that a name-change in one of your files would potentially cause this conflict? Here's the relevant thread on the TMP forum:

http://tmp.garyr.net/forum/viewtopic.php?f=2&t=18079&p=62178#p62176

Filbert-Cobb commented 10 years ago

FWIW - I am using TMP 0.4.1.0 and Sage 1.5.2b1 today and this combination is working as it should for L-click to open link in new tab from FF sidebar, mark all as read, check feeds. Any Sage version later than this does not work correctly with TMP on my machine

inspector71 commented 10 years ago

onemen from TMP has come up with the goods:

https://bitbucket.org/onemen/tabmixplus/commits/5bee48d45351b304be94daae0fb051f3219479c2