search

petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

Sage is not compatible with Multiprocess and will be disabled as of Firefox 57 #152

Open Canageek opened 7 years ago

Canageek commented 7 years ago

Sage is not currently compatible with Firefox Multiprocess. (Checked with Add-on Compatibility Reporter Version 2.2.4 ) This means that Sage will no longer function as of Firefox 57..

turmoni commented 7 years ago

Sage is XUL-based so unless I'm completely misunderstanding won't work from Firefox 57 regardless, without a lot of rework. However, I believe issue #140 is for the/a change that's required for multiprocess to work.

inspector71 commented 7 years ago

57 is when they're killing^ old extension APIs in favour of WebExtension addons.

It's correct that there's also the multiprocess (Electrolysis AKA e10s) issue that's already a limiting factor for Sage users. If you've got Sage right now, you won't have the performance benefits of multiprocess despite the essential fundamental issue with multiprocess being (AFAIK) per-page/tab and/or content vs chrome, which are not really issues that effect Sage because Sage doesn't really use per-tab/page/site (except maybe for feed discovery?), or 'content' functionality/APIs.

I'd really like to hear Pete's views on whether he has investigated Sage's multiprocess compatibility. I think there's some automatic, or semi-automatic tool(s) for determining compatibility but I'm not certain.

Until the last month or two, there wasn't even a WebExtension equivalent of the Add-on SDK (Jetpack?) sidebar API despite the sidebar being a component of Firefox Sync and Bookmarks UI. But there is now. I know I don't use Sage's full functionality so I may not be seeing the whole picture, but the WebExtension sidebars support seems fundamental to Sage and it's now available so maybe it's time to look at migration?

That all said, I would be willing to contribute however I could to a Sage WebExtension migration if only Pete would address the question of whether he's going to/has already, I understand there must be a lot of resentment towards the multiprocess and WebExtension changes that have come in quick succession and nuking the old APIs is a real kick in the balls to those who have written extensions in the past. I wish there was another option but Sage is too good to lose.

^ From Firefox 57 onwards, WebExtensions will be the only supported extension type, and Firefox will not load other types.

Canageek commented 7 years ago

Ah, I was conflating two issues it seems.

Yes, there is the Add-on Compatibility Reporter that reports compatibility with the current version and multiprocess.

inspector71 commented 7 years ago

I've used the Add-on Compatibility Reporter for a while. It's not overly useful. It probably should be renamed "Are your addons going to break/have broken" as that's all it does. Mozilla should be able to get some of that data itself through Firefox telemetry ("X Firefox instances ran for Y period of time and loaded Z addons that will break in 57").

As usual it would seem there's so many hands at Mozilla that nobody can coordinate them properly. I bet those developing the WebExtensions support don't even talk to those managing AMO who don't engage with the customer support team who can't initiate studies they need from the telemetry people ... etc etc. Very frustrating. I Imagine this was the case in the earlier part of the decade. Now everyone is deluded by this agile, immediate-term 'sprint' dogma permeating IT like a cancer, this disorganization and lack of coordination has likely gone from atrocious to abominable.