petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

No timeout when checking feeds #16

Closed petea closed 11 years ago

petea commented 11 years ago

Original author: neog...@gmail.com (June 27, 2010 22:29:37)

What steps will reproduce the problem?

  1. Check feeds
  2. Use a feed which takes an infinite amount of time to be checked (due to server not available or others problems) 3.

What is the expected output? What do you see instead? After x seconds if the connection can't be established or the connection takes too much time the application should pass to the next feed instead of looping for an infinite amount of time on the feed. The only way to fix this infinite loop is to delete the feed , close the sage tab, and recheck the feeds.

What version of the product are you using? On what operating system? All versions

Please provide any additional information below.

Original issue: http://code.google.com/p/sage/issues/detail?id=16

petea commented 11 years ago

From neog...@gmail.com on July 10, 2010 17:45:41 A simple timeout of, eg, 30 seconds will solve the problem.

petea commented 11 years ago

From jszelt...@gmail.com on June 08, 2011 14:58:57 Using FF 4.0.1 w/Sage 1.4.11 within XP SP 3:

Feed search fails to continue after reaching (exhaustive mode) a feed that fails to respond. The remaining feeds aren't searched and have to be searched individually.

Comment of 'neog...' indicates that I can set a time limit but I find nothing within Sage to allow me to do so.

petea commented 11 years ago

From neog...@gmail.com on June 08, 2011 20:03:51 @ jszeltzer it was a suggestion to a future improvement, i never talked of a feature implemented.

petea commented 11 years ago

From a.harrow...@gmail.com on August 16, 2012 10:36:18 Yes, this is a bug and one that ought to be trivial to fix. It's fairly common that at least one blog in a large roster is going to be "faily" on any given day, whether due to downtime, slashdot effect, or whatever.

Every version of Sage I've used (and I've been using it since 2007 or thereabouts) has this behaviour - the non-loading of a feed kills it. Interestingly, a feed parsing error is handled sensibly (marked as such and skipped) but a 404, 500, 502 etc is a crash.