search

petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

Feed list breaks on Firefox 4.0b1 #21

Closed petea closed 11 years ago

petea commented 11 years ago

Original author: bokunome...@gmail.com (July 08, 2010 05:06:51)

What steps will reproduce the problem?

  1. Update to Firefox 4.0b1.
  2. Check your sage feeds.
  3. Notice that all feed icons look the same (no indication of new feeds).

What is the expected output? What do you see instead? Sage checks and downloads new feeds, but there's no visual indication of new feeds (red star, bold text). Feed folders sport the same icon as the rest of feeds. Feed folders are expanded by default.

What version of the product are you using? On what operating system? Sage 1.4.6 on Windows XP SP 3.

Please provide any additional information below. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:2.0b1) Gecko/20100630 Firefox/4.0b1

Original issue: http://code.google.com/p/sage/issues/detail?id=21

petea commented 11 years ago

From yboujlil...@gtempaccount.com on July 08, 2010 07:54:19 Quick fix in sage.js: replace LMANNO_FEEDURI with PlacesUtils.LMANNO_FEEDURI replace _visibleElements with _rows (I guess there is a public getter somewhere)

petea commented 11 years ago

From bokunome...@gmail.com on July 08, 2010 10:33:02 The quick fix in comment 1 worked. Thanks a bunch. :)

petea commented 11 years ago

From PeterLa...@gmail.com on July 09, 2010 11:06:57 Should this issue be "Milestone: Sage1.4.7" and "Priority: High" because Sage will otherwise not work in the soon upcoming version of Firefox?

petea commented 11 years ago

From Peter.A....@gmail.com on July 21, 2010 17:16:14 Thanks for the feedback. We'll see if we can get this in the next release.

petea commented 11 years ago

From PeterLa...@gmail.com on July 22, 2010 09:34:38 FYI: Here's an official summary of the changes in Firefox 4 that add-on developers should know about:

"Add-on compatibility for Firefox 4 – time to get started" http://blog.mozilla.com/addons/2010/07/21/compatibility-for-firefox-4-time-to-get-started/

petea commented 11 years ago

From PeterLa...@gmail.com on July 26, 2010 20:59:44 Here's some relevant info on add-ons for Firefox 4 (Beta 2 coming soon):

https://developer.mozilla.org/web-tech/2008/12/08/firefox-31-beta-2-whats-new/

Relevant quote: "First and foremost, Firefox 3.1 Beta 2 should be stable enough for add-ons developers to start updating their add-ons for 3.1 compatibility. There will be a 3rd beta, but in between B2 and the RCs we will avoid changes that affect add-ons."

petea commented 11 years ago

From zviad.ki...@gmail.com on July 27, 2010 22:35:53 Hello, beta 2 is out and sage is not working :( pls update

petea commented 11 years ago

From Peter.A....@gmail.com on September 03, 2010 06:24:11 This issue was closed by revision a10cdc3894.

petea commented 11 years ago

From PeterLa...@gmail.com on September 03, 2010 11:08:12 The fix for this bug makes it possible to use Sage with Firefox beta4 and even the latest trunk nightly build of Firefox ("Minefield"). Thank you!!! I've been forced to use the official releases of Firefox for months, solely due to Sage not working in the nightly builds. Peter: you rock! Thank you!

NB: Interested observers can get the Sage beta from here: http://code.google.com/p/sage/downloads/list

PS. Does this also automatically fix issue #27?

petea commented 11 years ago

From o.p.pede...@gmail.com on September 04, 2010 13:55:33 @ PeterLairo,

My guess http://code.google.com/p/sage/issues/detail?id=27 would be closed only on final build of Firefox 4, issue 27 does not mention 'beta' anywhere, and wouldn't make sense to close that issue until a final build (even tho' Firefox 4 should have a complete code freeze before that, nobody can tell if Sage 1.4.7 will be 101% compatible yet?)

@Peter Andrews,

THANX a bunch, since 1.4.7beta1, I've been able to use Firefox 4 Beta build4 and 5 as my daily main browser again. Sage has somewhat become my number 1 add-on, and 'invalueable' to me, since no alternative can satisfy my needs even after months trying to adapt to them...