search

petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

Always open in new tab #56

Closed petea closed 11 years ago

petea commented 11 years ago

Original author: an0n1m...@gmail.com (March 28, 2011 00:24:25)

What steps will reproduce the problem?

  1. Install Sage 1.4.10, Firefox 4
  2. Open Sage sidebar, click a feed
  3. Click on an article

What is the expected output? What do you see instead?

Strictly the expect result is to open in the current active tab however I would like to set the Open in new tab to the default. Over the history of Sage this has been a browser setting that is either not respected or buggy and has never been something that Sage has a preference to tweak specifically for Sage.

On some installations this works. I have no idea why. Then mysteriously it stops working.

I always use Tab Mix Plus which provides my open in new tab behaviour for the url bar, search box, bookmarks etc. However historically either Sage does not respect the settings of Tab Mix Plus or something else it wrong.

What version of Sage are you using?

1.4.10

What version of Firefox are you using? On what operating system?

  1. I'd give you the whole UA string however the idiots have obscured that from Help -> About. Windows Vista build 6002 fully patched. This problem also happens on Windows XP though.

Please provide any additional information below.

My extensions (in case of compat issues)

<p>Application: Firefox 4.0 (20110318052756)<br /> Operating System: WINNT (x86-msvc)</p>

<p>Total number of items: 29</p>

<ul> <li><a href="http://adblockplus.org/en/&quot;&gt;Adblock Plus 1.3.3</a> <br />January 3, 2011 21:46:46 <br />Firefox 3.5 - 4.2a1pre <br />prism@developer.mozilla.org 1.0b1 - 1.0. <br />SeaMonkey 2.0 - 2.1b2 <br />Songbird 1.9.0a - 1.10.0a <br />Thunderbird 3.0 - 3.3a1pre <br />{a23983c0-fd0e-11dc-95ff-0800200c9a66} 1.0 - 1.1. <br />{a79fe89b-6662-4ff4-8e88-09950ad4dfde} 0.1 - 100.0 </li> <li><a href="https://addons.mozilla.org/collections&quot;&gt;Add-on Collector 2.0</a> <br />March 23, 2011 10:51:44 <br />September 15, 2010 11:22:45 <br />Firefox 3.6 - 4.0. <br />SeaMonkey 2.0 - 2.1b1 <br />Thunderbird 2.0 - 3.3a4pre <br />{a23983c0-fd0e-11dc-95ff-0800200c9a66} 1.0 - 4.0. </li> <li><a href="http://chatzilla.hacksrus.com/&quot;&gt;ChatZilla 0.9.86.1</a> <br />March 21, 2011 16:27:25 <br />Firefox 1.0 - 4.0. <br />Flock 0.4 - 1.0+ <br />Mozilla 1.0 - 1.8 <br />SeaMonkey 1.0 - 2.0. <br />Songbird 0.7 - 1.0 <br />{3db10fab-e461-4c80-8b97-957ad5f8ea47} 9.0b1 - 9.0. </li> <li><a href="http://www.andyhalford.com/checkplaces/index.html&quot;&gt;CheckPlaces 2.4.5</a> <br />March 21, 2011 16:27:25 <br />Firefox 3.0 - 4.0. </li> <li><a href="http://www.colorzilla.com/&quot;&gt;ColorZilla 2.5.5</a> <br />March 23, 2011 10:51:56 <br />September 15, 2010 11:22:53 <br />Firefox 3.0 - 4.0. <br />SeaMonkey 2.0 - 2.0. </li> <li><a href="http://www.diigo.com/&quot;&gt;Diigo Toolbar 5.1.0.22</a> <br />March 25, 2011 16:30:59 <br />Firefox 3.5 - 4.0. </li> <li><a href="http://downloadstatusbar.mozdev.org/&quot;&gt;Download Statusbar 0.9.8</a> <br />March 21, 2011 10:31:02 <br />Firefox 3.6 - 4.0. </li> <li><a href="http://www.captaincaveman.nl&quot;&gt;Drag & DropZones 1.5.1</a> <br />March 23, 2011 12:05:13 <br />Firefox 2.0 - 4.0. </li> <li><a href="http://adblockplus.org/en/elemhidehelper&quot;&gt;Element Hiding Helper for Adblock Plus 1.1.1</a> <br />March 21, 2011 10:31:02 <br />Firefox 3.5 - 4.2a1pre <br />prism@developer.mozilla.org 1.0b1 - 1.0. <br />SeaMonkey 2.0 - 2.1b3 <br />Songbird 1.9.0a - 1.10.0a <br />Thunderbird 3.0 - 3.3a3pre <br />{a79fe89b-6662-4ff4-8e88-09950ad4dfde} 0.1 - 100.0 </li> <li><a href="http://ed.agadak.net/&quot;&gt;Enter Selects 6</a> <br />November 10, 2009 19:22:14 <br />Firefox 3.0 - 4.0. </li> <li><a href="http://kondor.etf.bg.ac.yu/~kustodian/mozilla/esb&quot;&gt;Extended Statusbar 1.5.7</a> <br />February 21, 2011 10:18:52 <br />Firefox 2.0 - 4.0. </li> <li><a href="http://www.sogame.cat/&quot;&gt;Extension List Dumper 1.15.0</a> <br />March 28, 2011 11:19:43 <br />Firefox 1.5 - 4.0. <br />Flock 1.0 - 2. <br />Songbird 0.4 - 1.10.0a <br />Sunbird 0.3 - 0.9 <br />Thunderbird 1.5 - 3.1. </li> <li><a href="http://www.getfirebug.com/&quot;&gt;Firebug 1.7.0</a> <br />March 23, 2011 10:50:01 <br />February 8, 2011 16:05:12 <br />Firefox 4.0b12 - 4.0. <br />toolkit@mozilla.org 2.0.0 - 2.0.0. </li> <li><a href="https://addons.mozilla.org/en-US/firefox/addon/firefontfamily/?src=api&quot;&gt;FireFontFamily 0.1.1</a> <br />March 21, 2011 10:31:02 <br />Firefox 3.5 - 4.2a1pre </li> <li><a href="http://www.xuldev.org/firegestures/&quot;&gt;FireGestures 1.6.1</a> <br />January 4, 2011 12:18:07 <br />Firefox 3.5 - 4.0. </li> <li><a href="http://screenshot-program.com/fireshot/&quot;&gt;FireShot 0.88</a> <br />January 7, 2011 15:36:22 <br />Firefox 2.0 - 4.0. <br />SeaMonkey 2.0a1 - 2.1b2 <br />Thunderbird 2.0 - 3.3a1pre </li> <li><a href="https://addons.mozilla.org/firefox/addon/13505/&quot;&gt;Hide Caption Titlebar Plus 2.1.6</a> <br />February 2, 2011 10:26:48 <br />Firefox 3.5 - 4.0. </li> <li><a href="http://users.skynet.be/mgueury/mozilla/&quot;&gt;Html Validator 0.9.0.4</a> <br />March 23, 2011 10:51:54 <br />January 29, 2010 11:23:31 <br />Firefox 4.0b1 - 4.0. </li> <li><a href="http://www.graysonmixon.com/extension/&quot;&gt;IE View Lite 1.3.5</a> <br />September 15, 2009 19:05:06 <br />Firefox 3.1a1pre - 4.0. </li> <li><a href="http://imagezoom.yellowgorilla.net/&quot;&gt;Image Zoom 0.4.6</a> <br />January 4, 2011 12:18:08 <br />Firefox 3.0 - 4.0. <br />SeaMonkey 2.0 - 2.0. <br />Thunderbird 2.0 - 3.1. </li> <li><a href="http://frayd.us/&quot;&gt;MeasureIt 0.4.7</a> <br />March 23, 2011 10:51:30 <br />October 25, 2010 10:09:27 <br />Firefox 1.0 - 4.0. </li> <li><a href="http://code.google.com/speed/page-speed/&quot;&gt;Page Speed 1.10.2</a> <br />February 16, 2011 10:26:38 <br />toolkit@mozilla.org 1.9.0.5 - 2.0.0. </li> <li><a href="http://code.kliu.org/quickdrag/&quot;&gt;QuickDrag 2.1.0.1</a> <br />March 9, 2011 12:12:00 <br />Firefox 2.0a1 - 4.0. <br />SeaMonkey 2.0b1pre - 2.1b3 </li> <li><a href="http://sagerss.com&quot;&gt;Sage 1.4.10</a> <br />March 25, 2011 16:18:03 <br />Firefox 3.0b1 - 4.0. </li> <li><a href="https://addons.mozilla.org/en-US/firefox/addon/status-4-evar/?src=api&quot;&gt;Status-4-Evar 2011.03.21.22</a> <br />March 23, 2011 10:54:39 <br />Firefox 4.0 - 4.2a1pre </li> <li><a href="http://userstyles.org/&quot;&gt;Stylish 1.1.1</a> <br />March 4, 2011 11:27:59 <br />Firefox 3.5 - 4.0. <br />SeaMonkey 2.0 - 2.1b1 <br />Thunderbird 3.0 - 3.1. <br />toolkit@mozilla.org 1.9.1 - 2.0. </li> <li><a href="http://tmp.garyr.net&quot;&gt;Tab Mix Plus 0.3.8.5</a> <br />March 7, 2011 12:46:52 <br />Firefox 3.5 - 4.0. </li> <li><a href="http://jennifermadden.com&quot;&gt;View Source Chart 3.02</a> <br />September 9, 2010 16:48:45 <br />Firefox 1.0 - 4.0. </li> <li><a href="http://chrispederick.com/work/web-developer/&quot;&gt;Web Developer 1.1.9</a> <br />January 7, 2011 15:36:22 <br />Firefox 1.0 - 4.0. <br />Flock 1.0 - 2.6. <br />SeaMonkey 1.0 - 2.0.* </li> </ul>

Original issue: http://code.google.com/p/sage/issues/detail?id=57

petea commented 11 years ago

From an0n1m...@gmail.com on March 28, 2011 00:25:58 Damn code.google.com bug system for not parsing HTML, or not telling me it would not parse HTML before I entered this bug!

petea commented 11 years ago

From Peter.A....@gmail.com on March 28, 2011 16:11:49 Which browser setting are you referring to?

petea commented 11 years ago

From an0n1m...@gmail.com on March 29, 2011 05:03:16 Hi Peter

I wish I knew. I could perhaps manually reset it myself in about:config and not worry about hassling anyone :) My suspicion is it is a setting triggered by Tab Mix Plus. Please see top section of attachment. My about:config on my home XP system here (Vista system is at work) has the following about:config changes that seem to relate to the screenshot:

extensions.tabmix.opentabfor.bookmarks;true extensions.tabmix.opentabfor.history;true extensions.tabmix.opentabfor.urlbar;true

these are all marked as User Set. Presumably this means I set these preferences from within the Tab Mix Plus screenshot attached. What I have always wondered is whether 'Live Bookmarks' which is what I believe I use to create my Sage list, are covered by

extensions.tabmix.opentabfor.bookmarks;true

I am speaking vaguely here but over quite some time on different systems I am fairly certain that setting has been marked true yet Sage default to open in the current tab.

All I can say for sure is that right now on this Fx4 install using an upgraded non-fresh profile that preference is set to true and Sage is opening feed items in new tabs by default. I'll check this on my other XP Fx4 install. I guess I can toggle that preference but I really do not want to lose it's current ideal state :) I suppose I'll have to in order to sort this one out though! The things we do in the name of great extensions huh? LOL

petea commented 11 years ago

From an0n1m...@gmail.com on March 29, 2011 05:54:19 ok I toggled:

extensions.tabmix.opentabfor.bookmarks;true

in about:config and the default changed to open in current tab if that settings in false and open in new tab if that setting is true. Thankfully it flipped back just as easily as it flipped :)

Perhaps in some strange case there is a scenario where this setting is not respected by Sage, or wasn't respected in the past? Hmmm, hard to be sure.

I'll flip this preference on my other machines and see if I can replicate the same experience.

petea commented 11 years ago

From an0n1m...@gmail.com on March 29, 2011 06:01:06 OK things are looking good in terms of predictability (isn't it a nightmare trying to chase down bugs that are not behaving consistently?).

My second XP Fx4 machine, with Tabs Mix Plus and Sage 1.4.10 behaves the same. Maybe I've finally got a handle on this?

petea commented 11 years ago

From an0n1m...@gmail.com on March 31, 2011 01:25:57 The plot thickens!

Back @ work on my Vista Fx4 install. about config has the mysterious pref:

extensions.tabmix.opentabfor.sage;true

I've no idea where this came from and why it was set to false. I set it to true and Sage works as expected. However sage would work as expected with just the previously mentioned

extensions.tabmix.opentabfor.bookmarks;true

I expect.

I should be able to prove this by removing

extensions.tabmix.opentabfor.sage;true

from my prefs.js

...

Yep, there you go. How very strange. I wonder if Tab Mix Plus ever had a distinct setting for Sage? If so, I can't see a way to toggle it in the Options UI anywhere.

petea commented 11 years ago

From Peter.A....@gmail.com on April 05, 2011 03:31:04 Interesting. I'm not familiar with Tab Mix Plus, but it sounds like it's giving you the functionality you're looking for in Sage. I think it's best to leave this sort of behavior modification to another extension that changes it broadly, rather than creating an option in Sage that affects only a limited part of the user's experience.

petea commented 11 years ago

From Peter.A....@gmail.com on May 09, 2011 20:57:18 I recently noticed that one way to get this behavior in Firefox 4 is to pin the Sage tab. This causes links in the feed content to open in a new tab.