petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

Feed items without links behave poorly in Sage #67

Open petea opened 11 years ago

petea commented 11 years ago

Original author: jef.posk...@gmail.com (May 29, 2011 17:31:48)

I have come across an RSS feed, apparently exported from iTunes, which exhibits poor behavior when viewed in Sage.

The RSS feed's URL is: http://shows.kingdomofloathing.com/ahd/videogameshotdog.xml

The problems I see are: 1) Clicking on an item's title in the sidebar does nothing. 2) After having listened to an item by clicking on the Enclosure link in the main pane, the title does not change from boldface to regular.

The cause of this behavior is easy to see if you look at the feed's source - the items have an enclosure element but no link element. I checked the RSS 2.0 spec and this is legal - all sub-elements of an item are optional.

Would it be reasonable for Sage to treat item/enclosure URLs the same as item/link URLs?

I am using Sage 1.4.11, the current version. I am using Firefox 4.0.1 on Windows Vista.

Original issue: http://code.google.com/p/sage/issues/detail?id=68

petea commented 11 years ago

From Peter.A....@gmail.com on June 12, 2011 04:15:31 This is an interesting case. Sage relies on feed item links to record read/unread state and to support several other behaviors, so when they're not present there's going to be a problem. I don't think we'll want to substitute the enclosure link in this situation, and we can't assume there will be one anyway.