search

petea / sage

A feed reader for Firefox.
http://sagerss.com
27 stars 8 forks source link

isLivemark interface has been removed in Firefox 22 and Sage is not working anymore #93

Closed gialloporpora closed 11 years ago

gialloporpora commented 11 years ago

I have updated yesterday to Firefox 22 (Aurora channel) and Sage no works anymore. I think the problem is caused by this change in Firefox's Places API: https://developer.mozilla.org/en-US/docs/Firefox_21_for_developers

nsILivemarkService::* PlacesUtils.itemIsLivemark PlacesUtils.nodeIsLivemarkContainer PlacesUtils.nodeIsLivemarkItem

A similar message is shown also in the release version saying that islivemarks is deprecated. I'am trying to fix this issue by myself, but, unfortunatelly, I have no required skills.

This is the exact error (there are other similar errors in console):

Data e ora: 06/04/2013 17.01.22Errore: TypeError: PlacesUtils.nodeIsLivemarkItem is not a function File sorgente: chrome://sage/content/sage.js Riga: 185

petea commented 11 years ago

Thanks for pointing this out. Looks like it's time to remove Livemarks support.

petea commented 11 years ago

I've made a beta release that includes almost all of the Firefox 22 compatibility work. Any feed back would be appreciated.

http://sagerss.com/blog/2013/06/sage-1-5-beta-ready-for-testers/

petea commented 11 years ago

Related Get Satisfaction thread:

https://getsatisfaction.com/sagerss/topics/sage_does_not_work

gialloporpora commented 11 years ago

Thanks Peter. I have installed it. After a preliminary test I have not found issues (only issues already known and listed in realease notes). I have a question. I have seen that in IT locale some strings is missing, I could modify the related file on this repository and make a pull request? Sandro

I've made a beta release that includes almost all of the Firefox 22 compatibility work. Any feed back would be appreciated.

http://sagerss.com/blog/2013/06/sage-1-5-beta-ready-for-testers/

Reply to this email directly or view it on GitHub: https://github.com/petea/sage/issues/93#issuecomment-19848373

Joni Mitchell – Little Green http://www.last.fm/music/Joni+Mitchell/_/Little+Green Give me a place to stand, and I will move the earth.

petea commented 11 years ago

Yes, that would be very much appreciated!

I have a question. I have seen that in IT locale some strings is missing, I could modify the related file on this repository and make a pull request?

kayceejay commented 11 years ago

Beta 3 is working great for me with release Firefox 22, thanks!

petea commented 11 years ago

kayceejay: don't forget to upgrade to the 1.5 release.

http://sagerss.com/blog/2013/06/sage-1-5-released/

yagodlt commented 11 years ago

Thanks @petea and everyone else involved for tackling this so quickly and efficiently :100: