peteb / tankage

Multiplayer 2D tank game; drive around in a mutable world together with friends
10 stars 2 forks source link

Missing CMake find modules #6

Closed kskels closed 13 years ago

kskels commented 13 years ago

In src/graphics/CMakeLists.txt there are requests for png and jpeg find modules which are missing. It's not possible to even to 'cmake .' with having them.

peteb commented 13 years ago

I changed them to PNG and JPEG, I think they are valid modules in CMake 2.8 and it works for me. I don't know in which version of CMake they were introduced, though.

kskels commented 13 years ago

Yep, I tried with fresh repository and it works :) Seems that capital letters were needed!

-- Could NOT find PNG (missing: PNG_LIBRARY PNG_PNG_INCLUDE_DIR) -- Found JPEG: /usr/lib/libjpeg.so

peteb commented 13 years ago

Great :) Mac OS X is most often case-insensitive when it comes to filenames, but Ubuntu might be the other way. I'll keep this in mind. I'd prefer if we could remove the libpng and libjpeg dependencies completely and just use DevIL as the only dependency. Ideally, it would contain everything that's needed. Thanks!