search

petebacondarwin / github-pr-helper

This adds sorely needed features to GitHub's PR pages.
49 stars 6 forks source link

Add OAuth support #14

Open ProLoser opened 10 years ago

ProLoser commented 10 years ago

You can add OAuth support to chrome extensions. I did it in Github-Omnibox. Any interest in merging projects? I've already incorporated several Github fixes into the extension and was looking to add more.

petebacondarwin commented 10 years ago

I'd love to get OAuth working. I played with it for a while but couldn't get my head around it. I would be interested to chat with you about your experience of getting this going with GH-omnibox. Is there a difference in that this project has no background pages to refer back to?

I not keen on merging the projects at this point. I think it is better that extensions are well defined and do a single thing well. The omni-box functionality is quite a different tool to this extension, which is really just a polyfill until GH actually sorts itself out and provides the UI out of the box.

ProLoser commented 10 years ago

I actually have a few other polyfills installed too and sort of hope that they become built in too.

The trick is to use a background page hack. I will link you to the resource I used tomorrow. On Nov 26, 2013 1:25 AM, "Pete Bacon Darwin" notifications@github.com wrote:

I'd love to get OAuth working. I played with it for a while but couldn't get my head around it. I would be interested to chat with you about your experience of getting this going with GH-omnibox. Is there a difference in that this project has no background pages to refer back to?

I not keen on merging the projects at this point. I think it is better that extensions are well defined and do a single thing well. The omni-box functionality is quite a different tool to this extension, which is really just a polyfill until GH actually sorts itself out and provides the UI out of the box.

— Reply to this email directly or view it on GitHubhttps://github.com/petebacondarwin/github-pr-helper/issues/14#issuecomment-29277866 .

petebacondarwin commented 10 years ago

Great. Thanks - ping me with any specific poly fills that you think would work well in a project together.

On 26 November 2013 09:42, Dean Sofer notifications@github.com wrote:

I actually have a few other polyfills installed too and sort of hope that they become built in too.

The trick is to use a background page hack. I will link you to the resource I used tomorrow. On Nov 26, 2013 1:25 AM, "Pete Bacon Darwin" notifications@github.com wrote:

I'd love to get OAuth working. I played with it for a while but couldn't get my head around it. I would be interested to chat with you about your experience of getting this going with GH-omnibox. Is there a difference in that this project has no background pages to refer back to?

I not keen on merging the projects at this point. I think it is better that extensions are well defined and do a single thing well. The omni-box functionality is quite a different tool to this extension, which is really just a polyfill until GH actually sorts itself out and provides the UI out of the box.

— Reply to this email directly or view it on GitHub< https://github.com/petebacondarwin/github-pr-helper/issues/14#issuecomment-29277866>

.

— Reply to this email directly or view it on GitHubhttps://github.com/petebacondarwin/github-pr-helper/issues/14#issuecomment-29278847 .

ProLoser commented 10 years ago

This is the lib I used (see the implementation in my app) https://github.com/borismus/oauth2-extensions

As for 'polyfills'. There's a modification where if there exists a gh-pages branch but no project url, one is added automatically to the gh-pages branch io page.

Also, we've incorporated several build / dependency status icons into the side navigation that we want to allow people to customize. It will appropriately change depending on the project type too.

I just figured of coming up with an abstract GithubUpgrades package similar to YouTubeCenter, which built up quite a following.

I also wanted to continue a project I briefly started at an AngularJS/FireBase hackathon to allow you to add metadata to github issues (either through the extension OR through another webpage) such as voting, assigning to clients, or allowing guests to label/tag/whatever. This would essentially turn Github into a full-powered issue tracker.

petebacondarwin commented 10 years ago

Personal access tokens are the way forward. Will also fix #16