search

peteboere / css-crush

CSS preprocessor.
http://the-echoplex.net/csscrush
MIT License
537 stars 51 forks source link

Punctuation in /* comment's */ breaks code #6

Closed Hlight closed 13 years ago

Hlight commented 13 years ago

I was having problems with importing certain style sheets with css crush. After testing I found the culprit to be punctuation in css comments. If there is any punctuation at all in the comments it seems to break the code.

peteboere commented 13 years ago

Thanks, would be helpful if you could post an example of the code that is causing the issue so I can test it locally

Hlight commented 13 years ago

Okay, here is an example: (update: only single quotation marks are causing problems)

/* comments with single quotes break css_crush */ <- WORKS (notice no single quotes in string)

/* comment's with single quotes break css_crush */ <- BREAKS (page freezes when css_crush processes css file)

/* comment's with single quote's break css_crush */ <- WORKS! (b/c there are two single quotation marks thus php is interpreting the single quotes as normal php "opening" & "closing" tags for a string).

Hope this helps, seems that the comments strings need to be escaped before they are processed further in the code.

I keep having problems with the page freezing up whenever I add css that contains comments with single quotes. Tested this pretty thoroughly. BTW, thanks for making this I'm diggin css_crush ;)

peteboere commented 13 years ago

This issue is now resolved

Hlight commented 13 years ago

Awesome! thank you so much.

On Thu, Jul 14, 2011 at 5:54 AM, peteboere < reply@reply.github.com>wrote:

This issue is now resolved

Reply to this email directly or view it on GitHub: https://github.com/peteboere/css-crush/issues/6#issuecomment-1571250