search

petebrew / fhaes

Fire History Analysis and Exploration System
GNU General Public License v3.0
4 stars 1 forks source link

GUI problems using EARLIEST_ALLOWED_YEAR #72

Closed petebrew closed 9 years ago

petebrew commented 10 years ago

The setting of EARLIEST_ALLOWED_YEAR to Integer.MIN_VALUE means the earliest year the system supports is 2147483648 BC. While it's cool that we effectively don't have hard coded limits to dates, it does mean that the JSpinners are much wider than they'll ever need to be taking up screen real estate. I think we could set the earliest year to -99999 are be certain that we'll never hit the limit. Doing so seems to have a knock on effect elsewhere in the code with a the following exception thrown by the JSpinner:

java.lang.IllegalArgumentException: (minimum <= value <= maximum) is false

Original comment by: petebrew

petebrew commented 10 years ago

Original comment by: valorcrow

petebrew commented 10 years ago

All objectives complete and implemented, however I was not ever able to replicate the illegalArgumentException scenario as described in this ticket. During this fix I also ended up overhauling the system used to determine values for the jspinners so the error may have been avoided in doing that.

Original comment by: valorcrow