search

petebrowne / sprockets-helpers

Asset path helpers for Sprockets 2.0 applications
MIT License
96 stars 33 forks source link

javascript_tag helper conflict #20

Open dwradcliffe opened 11 years ago

dwradcliffe commented 11 years ago

Is there a reason you used javascript_tag instead of javascript_include_tag? I'm finding that other gems are trying to use javascript_tag to include a script tag with content and I can't because this gem has overwritten that helper.

Offending code: https://github.com/petebrowne/sprockets-helpers/blob/5997d47ca77128b4f1dfaf6fd5c58d5ff25a49a7/lib/sprockets/helpers.rb#L155-L160

It would make more sense to me to leave javascript_tag alone.

petebrowne commented 11 years ago

Yeah I'm not sure what to do to avoid conflicts - it's kind of a running problem. I'm not sure javascript_include_tag is the way to go either...maybe if there was a way to declare what method names to use when including?