search

petebrowne / sprockets-sass

Better Sass integration with Sprockets 2.x
MIT License
90 stars 29 forks source link

[BuG fix] V3 importer was not detecting engines registered on a file extension #41

Closed bogdanRada closed 7 years ago

bogdanRada commented 7 years ago

This fixes also this https://github.com/petebrowne/sprockets-sass/pull/40

After some research i found how to detect engines registered on a file extension.

Tested also and works like a charm.

Apparently it seems i no longer have to delete this line context.metadata.delete(:data) from handle_complex_process_result. Seems to work just fine with that line too.

Let me know what you think. Thanks.

bogdanRada commented 7 years ago

Travis Failed for ruby 2.0 and 2.1.5 because of an issue with bundler on Travis itself, it somehow requires an older version of bundler. I left a comment on this travis-ci/travis-ci#5831 for that, maybe we should use ruby > 2.2.2 for travis .

Tests are passing locally for all ruby versions.

bogdanRada commented 7 years ago

@petebrowne , can you please review this pull request?

bogdanRada commented 7 years ago

Would be nice if we could drop from Travis ruby 2.0 ( since is not maintained anymore ) and maybe 2.1.5 from Travis...they are only causing issues with bundler on Travis and i don't know any workarounds for them.

petebrowne commented 7 years ago

That's fine with me

bogdanRada commented 7 years ago

Done. Updated travis.yml file . Let me know if anything needs updating or more tests . Thank you very much

bogdanRada commented 7 years ago

Thank you very much :)

bogdanRada commented 7 years ago

can you also release a new version to rubygems so others can benefit from this bug fix? Thanks.

petebrowne commented 7 years ago

Released as 2.0.0.beta2

bogdanRada commented 7 years ago

Thanks a lot :)