search

petecoop / phantasma

A high level promise based wrapper for phantomjs
ISC License
33 stars 8 forks source link

extractDomElement() with tests and everything #24

Closed Mako-L closed 9 years ago

Mako-L commented 9 years ago

extractDomElement() with tests and everything

petecoop commented 9 years ago

Hey thanks for this looking good, I've just put a couple of comments, if you could sort those out it'll look good to merge

Mako-L commented 9 years ago

All works well. 'Huston we are ready to deploy the function into production.' Just say 'Roger that AphaOne I'll press Enter.' and merge it.

petecoop commented 9 years ago

errrr.... Roger that AphaOne I'll press Enter.

petecoop commented 9 years ago

and published as 1.2.0, thanks :+1: I appreciate the commitment you're taking to the project